Skip to content

Run the 'JUnitToAssertj' OpenRewrite recipe #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

Run the 'JUnitToAssertj' OpenRewrite recipe #311

merged 1 commit into from
Jul 20, 2025

Conversation

@making
Copy link
Member

@making making commented May 20, 2025 •
edited
Loading

fixes gh-293

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.testing.assertj.JUnitToAssertj -Drewrite.exportDatatables=true

@backpaper0
Copy link
Member

backpaper0 commented May 20, 2025

org.hamcrest.MatcherAssert.assertThat, org.junit.jupiter.api.Assertions.assertThrows, and org.junit.jupiter.api.Assertions.fail are still remaining.
Would you like to remove them in this PR, or remove them in a separate one?

@github-actions
Copy link

github-actions bot commented Jul 20, 2025

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Jul 20, 2025
@backpaper0
Copy link
Member

backpaper0 commented Jul 20, 2025

org.hamcrest.MatcherAssert.assertThat, org.junit.jupiter.api.Assertions.assertThrows, and org.junit.jupiter.api.Assertions.fail are still remaining. Would you like to remove them in this PR, or remove them in a separate one?

We'll handle it in a separate pull request and go ahead with merging this one.

@backpaper0 backpaper0 merged commit a9b798b into master Jul 20, 2025
6 checks passed
@backpaper0 backpaper0 deleted the gh-293 branch July 20, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to AssertJ

3 participants

@making @backpaper0